Horton
Menu

Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string

Masahiko Sawada <sawada.mshk@gmail.com>

View thread
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, tharakan@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2025-03-12T23:24:39Z
Lists: pgsql-bugs 
On Wed, Mar 12, 2025 at 3:00 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Wed, Mar 12, 2025 at 02:33:36PM -0700, Masahiko Sawada wrote:
> > Thank you for the report! David also reported the same issue[1]. I've
> > just pushed the fix.
>
> Oh, sorry, I should've checked that list first.
>
> > BTW how did you catch the warning? I checked before the push if the
> > change had passed the CI tests (completed with green status). But when
> > checking the build log now, I can see the warning in the build logs.
>
> I noticed a ⚠ next to the results on http://cfbot.cputube.org/.

That's good to know. Thank you. I'll add it to my pre-commit check routine.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_logicalinspect: Fix possible crash when passing a directory path.

  2. Add contrib/pg_logicalinspect.

  3. Fix compiler warning on Windows.