Re: pg_create_logical_replication_slot returns text instead of name
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-07-13T02:28:01Z
Lists: pgsql-hackers
On Fri, Jul 13, 2018 at 11:22 AM, Michael Paquier <michael@paquier.xyz> wrote: > On Fri, Jul 13, 2018 at 11:14:01AM +0900, Masahiko Sawada wrote: >> Hmm, I'm also not sure about the policy of usage of name data type for >> columns that show an object identifier on external servers. There is a >> similar case; we have the pubname in pg_subscritpion as name type >> whereas the subpublications in pg_subscription is text[] type. > > Let's not bother then. In the case of the function you pointed out the > intention behind the code was clear anyway, so that's better now. Yeah, I agreed with you. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
Commits
-
Fix argument of pg_create_logical_replication_slot for slot name
- ce89ad0fa07d 12.0 landed