Re: effective_wal_level is not decreasing after using REPACK (CONCURRENTLY)

Masahiko Sawada <sawada.mshk@gmail.com>

From: Masahiko Sawada <sawada.mshk@gmail.com>

To: Álvaro Herrera <alvherre@kurilemu.de>

Cc: shveta malik <shveta.malik@gmail.com>, Imran Zaheer <imran.zhir@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, shveta malik <shvetamalik@gmail.com>

Date: 2026-05-27T18:25:19Z

Lists: pgsql-hackers

On Wed, May 27, 2026 at 11:20 AM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2026-May-26, shveta malik wrote:
>
> > On Tue, May 26, 2026 at 3:09 PM Imran Zaheer <imran.zhir@gmail.com> wrote:
> > >
> > > Hi,
> > >
> > > Thanks Shveta,  I agree with the additional sanity checks and comments.
> >
> > Thanks, v3 LGTM.
>
> Thanks!  Pushed with some cosmetic changes.

Thank you for pushing the patch!

>
> One of them was that I wasn't sure of the reason why ApplyLauncherMain()
> isn't requesting logical decoding disable upon dropping the slot, so
> there's now an XXX comment there.

This is because the launcher can acquire only CONFLICT_DETECTION_SLOT
slot and it is a physical slot.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com