Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
Li Japin <japinli@hotmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2021-08-06T23:50:19Z
Lists: pgsql-hackers
On Fri, Aug 6, 2021 at 2:50 PM Amit Kapila <amit.kapila16@gmail.com> wrote: > > On Fri, Aug 6, 2021 at 10:09 AM Amit Kapila <amit.kapila16@gmail.com> wrote: > > > > On Fri, Aug 6, 2021 at 5:09 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > > > > > > But, isn't this happening because of your suggestion to compare the > > current set of relations with relations from publications that doesn't > > need to be removed? Do we have better ideas to fix or shall we just > > say that we will refresh based on whatever current set of relations > > are present in publication to be dropped? > > > > The other options could be that (a) for drop publication, we refresh > all the publications, (b) for both add/drop publication, we refresh > all the publications. > > Any better ideas? > > As this is introduced in PG-14 via the below commit, I am adding > authors and committer to see if they have any better ideas. > > commit 82ed7748b710e3ddce3f7ebc74af80fe4869492f > Author: Peter Eisentraut <peter@eisentraut.org> > Date: Tue Apr 6 10:44:26 2021 +0200 > > ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION > > Author: Japin Li <japinli@hotmail.com> > Author: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> > I've added this to Open Items. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
Commits
-
Fix Alter Subscription's Add/Drop Publication behavior.
- 5cfcd46e9d29 14.0 landed
- 1046a69b3087 15.0 landed
-
ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION
- 82ed7748b710 14.0 cited