Re: BUG #17695: Failed Assert in logical replication snapbuild.
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: bowenshi <zxwsbg@qq.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Date: 2023-05-17T05:34:35Z
Lists: pgsql-bugs
Attachments
- reset_next_phase_at.patch (application/octet-stream) patch
On Mon, Mar 27, 2023 at 8:49 PM Daniel Gustafsson <daniel@yesql.se> wrote: > > This thread has been idle for quite some time, and the test isn't running at > all, whereas there is more activity on the linked thread. AFAICT from the > thread this issue is reproducible in HEAD so the test should be for master > right? Should this be closed in favor of the other patch? > Reviewing the thread, one assertion failure was reported[1] and then another assertion failure was reported[2]. But the later one was already under discussion on another thread[3]. So I think we should tackle the former one (i.e. originally reported issue) on this thread. When it comes to the original issue, I already shared the reproducible steps[4] and I've confirmed again with the steps that the issue still happens on 14 or later and the patch . However I don't find a way to reproduce it without sleep/gdb attach. The fix is straightforward and it seems OK to me but the regression test part might need more discussion. Regards, [1] https://www.postgresql.org/message-id/17695-6be9277c9295985f%40postgresql.org [2] https://www.postgresql.org/message-id/tencent_7EB71DA5D7BA00EB0B429DCE45D0452B6406%40qq.com [3] https://www.postgresql.org/message-id/CAA4eK1L8wYcyTPxNzPGkhuO52WBGoOZbT0A73Le=ZUWYAYmdfw@mail.gmail.com [4] https://www.postgresql.org/message-id/CAD21AoCsxvV3Mpzv8Q3hG7CdQZ7vSBWyEFLgY3QZARRDcgzVwA%40mail.gmail.com -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix assertion failure in snapshot building
- 0f404c581247 15.13 landed
- 7be51eb4e169 14.18 landed
- eb27d3dc8887 16.0 landed
- 48efb2302bea 17.0 landed
-
Fix perl warning from commit 9b4eafcaf4
- c93254424f28 14.7 cited