Horton

Re: Spinlock is missing when updating two_phase of ReplicationSlot

Masahiko Sawada <sawada.mshk@gmail.com>

View thread View on postgr.es
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-01-12T05:05:44Z
Lists: pgsql-hackers 
On Thu, Jan 12, 2023 at 1:42 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Wed, Jan 11, 2023 at 02:36:17PM +0900, Michael Paquier wrote:
> > Looks right to me, the paths updating the data related to the slots
> > are careful about that, even when it comes to fetching a slot from
> > MyReplicationSlot.  I have been looking around the slot code to see if
> > there are other inconsistencies, and did not notice anything standing
> > out.  Will fix..
>
> And done, thanks!

Thank you!

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Commits

  1. Acquire spinlock when updating 2PC slot data during logical decoding creation

  2. Add support for prepared transactions to built-in logical replication.