Horton

Re: pgsql: pg_upgrade: Preserve default char signedness value from old clus

Masahiko Sawada <sawada.mshk@gmail.com>

View thread View on postgr.es
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Masahiko Sawada <msawada@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-03-18T04:35:43Z
Lists: pgsql-hackers 
On Mon, Mar 17, 2025 at 8:02 PM Robert Haas <robertmhaas@gmail.com> wrote:
>
> On Mon, Mar 17, 2025 at 6:02 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > I've confirmed the issue and attached a patch to fix it.
>
> Cool. The commit message refers to 003_char_signedness, but the test
> name is 005, not 003.

Thank you for reviewing the patch. I've pushed the patch after fixing it.


Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Commits

  1. Fix the test 005_char_signedness.

  2. pg_upgrade: Preserve default char signedness value from old cluster.

  3. Add default_char_signedness field to ControlFileData.