Re: Unmark gen_random_uuid() function leakproof
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-12-09T22:48:51Z
Lists: pgsql-hackers
Attachments
- v2-0001-Unmark-gen_random_uuid-function-leakproof.patch (application/octet-stream) patch v2-0001
On Mon, Dec 9, 2024 at 2:23 PM Andres Freund <andres@anarazel.de> wrote: > > Hi, > > On 2024-12-09 14:10:30 -0800, Masahiko Sawada wrote: > > While reviewing UUIDv7 patch[1], I realized gen_random_uuid() is > > marked leakproof even though it doesn't take arguments. The functions > > without arguments don't need to be marked leakproof in principle. This > > is the sole function that has no arguments and is listed in the "List > > of built-in leakproof functions" in opr_sanity.sql. I've attached the > > patch for fixing it and for better consistency with new UUID > > generation functions discussed on that thread. > > Seems like it'd make sense to add a test to opr_sanity.sql so we don't > reintroduce such cases? > Thank you for the comment. It's a good idea. I've updated the patch. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
Commits
-
Unmark gen_random_uuid() function leakproof.
- 398d3e3b5b8f 18.0 landed