Horton

Re: [BUG] wrong refresh when ALTER SUBSCRIPTION ADD/DROP PUBLICATION

Masahiko Sawada <sawada.mshk@gmail.com>

View thread View on postgr.es
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Japin Li <japinli@hotmail.com>
Date: 2021-08-24T01:42:26Z
Lists: pgsql-hackers 
On Tue, Aug 24, 2021 at 10:01 AM houzj.fnst@fujitsu.com
<houzj.fnst@fujitsu.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Masahiko Sawada <sawada.mshk@gmail.com>
> > Sent: Tuesday, August 24, 2021 8:52 AM
> >
> > Thanks. The patch for HEAD looks good to me. Regarding the patch for PG14, I
> > think we need to update the comment as well:
> >
> > @@ -987,7 +986,7 @@ AlterSubscription(AlterSubscriptionStmt *stmt, bool
> > isTopLevel)
> >       PreventInTransactionBlock(isTopLevel, "ALTER SUBSCRIPTION with
> > refresh");
> >
> >       /* Only refresh the added/dropped list of publications. */
> > -     sub->publications = stmt->publication;
> > +     sub->publications = publist;
> >
>
> Thanks for the comment, attach new version patch which fixed it.

Thank you for updating the patch! Looks good to me.

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

Commits

  1. Fix Alter Subscription's Add/Drop Publication behavior.

  2. ALTER SUBSCRIPTION ... ADD/DROP PUBLICATION