Re: pg_stop_backup(wait_for_archive := true) on standby server
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>,
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-07-07T08:06:04Z
Lists: pgsql-hackers
On Fri, Jul 7, 2017 at 4:21 PM, Michael Paquier <michael.paquier@gmail.com> wrote: > On Fri, Jul 7, 2017 at 4:06 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote: >> I agree with this idea. I've tried to make it wait for archiving but >> it seems to me that there are other two issues we need to deal with: >> the timeline ID on standby server is always reset after created a >> restart point, and ThisTimeLineID variable of a backend process is not >> set on the standby node when initializing. The former would be easy to >> fix because resetting it is for debugging purposes. However, to deal >> with latter issue, I'm considering the influence on other things. > > ThisTimeLineID does not need to be touched. It seems to me that you > should just use the wait timeline as minRecoveryPointTLI, and wait for > segments using this value. The segment and backup history files to > wait for should be defined with minRecoveryPoint. Thank you for the advise. I'll post the patch later. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
Commits
-
Make pg_stop_backup's wait_for_archive flag work on standbys.
- 52f8a59dd953 10.0 landed
-
Implement backup API functions for non-exclusive backups
- 7117685461af 9.6.0 cited