Re: Log a sample of transactions

Masahiko Sawada <sawada.mshk@gmail.com>

From: Masahiko Sawada <sawada.mshk@gmail.com>

To: Adrien NAYRAT <adrien.nayrat@anayrat.info>

Cc: Andres Freund <andres@anarazel.de>, "Kuroda, Hayato" <kuroda.hayato@jp.fujitsu.com>, "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>

Date: 2019-03-28T09:40:24Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Tweak docs for log_statement_sample_rate
- d1f04b96b99d 12.0 landed

On Thu, Mar 28, 2019 at 6:33 PM Adrien NAYRAT
<adrien.nayrat@anayrat.info> wrote:
>
> Hello,
>
> On 3/28/19 3:18 AM, Masahiko Sawada wrote:
> >>>
> >>> Sorry, I changed that, someone suggest using either "0" and "1", or
> >>> "0.0" and "1.0" but not mixing both.
> >
> > Agreed with using "0.0" and "1.0".
> >
> >>> I will remove this change.
> >>>
> >
> > --- a/src/backend/utils/misc/postgresql.conf.sample
> > +++ b/src/backend/utils/misc/postgresql.conf.sample
> > +#log_transaction_sample_rate = 0       # Fraction of transactions
> > whose statements
> > +                                       # are logged regardless of
> > their duration. 1.0 logs all
> > +                                       # statements from all
> > transactions, 0 never logs.
> >
> > --- a/src/backend/utils/misc/guc.c
> > +++ b/src/backend/utils/misc/guc.c
> > +               {"log_transaction_sample_rate", PGC_SUSET, LOGGING_WHEN,
> > +                       gettext_noop("Set the fraction of transactions
> > to log for new transactions."),
> > +                       gettext_noop("Logs all statements from a
> > fraction of transactions. "
> > +                                                "Use a value between
> > 0 (never log) and 1 (log all "
> > +                                                "statements for all
> > transactions).")
> >
> > I think it would be better to use the same number in both guc.c and
> > postgresql.conf.sample. How about unifying them to "0.0" and "1.0" for
> > consistency?
> >
>
> I changed to use both 0.0 and 1.0.
>

Thank you for updating the patch!

The patch looks good to me. I'll mark this patch as Ready for
Committer if other reviewer has no review comment on v7 patch.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center