Re: [Proposal] Allow users to specify multiple tables in VACUUM commands

Masahiko Sawada <sawada.mshk@gmail.com>

From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: "Bossart, Nathan" <bossartn@amazon.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2017-05-18T06:45:36Z
Lists: pgsql-hackers
On Thu, May 18, 2017 at 3:19 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Thu, May 18, 2017 at 2:59 PM, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>> It seems to me that it's not good idea to forcibly set ANALYZE in
>> spite of  ANALYZE option is not specified. One reason is that it would
>> make us difficult to grep it from such as server log. I think It's
>> better to use the same vacuum option to the all listed relations.
>
> Even now, if you use VACUUM without listing ANALYZE directly, with
> relation listing a set of columns, then ANALYZE is implied.

Oh.. I'd missed that behavior. Thanks!

>  I agree
> with your point that the same options should be used for all the
> relations, and it seems to me that if at least one relation listed has
> a column list, then ANALYZE should be implied for all relations.

+1

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


Commits

  1. Allow multiple tables to be specified in one VACUUM or ANALYZE command.

  2. Give a better error for duplicate entries in VACUUM/ANALYZE column list.

  3. Reject ANALYZE commands during VACUUM FULL or another ANALYZE.