Horton

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

Masahiko Sawada <sawada.mshk@gmail.com>

View thread
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: shveta malik <shveta.malik@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-12-19T08:47:24Z
Lists: pgsql-hackers 
On Thu, Dec 18, 2025 at 7:53 PM shveta malik <shveta.malik@gmail.com> wrote:
>
> On Fri, Dec 19, 2025 at 6:13 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > >
> >
> > I've rebased the patch and addressed the review comments.
> >
> > Regards,
> >
>
> Thanks for the patch.
>
> 1)
> + * There could be some transactions that might have started with the old
> + * status, but we don't need to wait for these transactions to complete as
> + * long as they valid XIDs. These transactions will appear in the
>
> they valid --> they have valid
>
> 2)
> + * One might think we need to wait for all running transactions, including
> + * read-only transactions, to finish before enabling logical decoding.
>
> Suggestion to change it slightly to make it more clear:
> One might think we need to wait for all running transactions,
> including those without XIDs and read-only ones, to finish before
> enabling logical decoding.
> ~~
>
> Apart from the above trivial corrections, I have no more comments.
> I’ll conclude my review here; the patch LGTM.

Thank you for reviewing the patch! Agreed. I've incorporated these comments.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com