Horton

Re: Skipping logical replication transactions on subscriber side

Masahiko Sawada <sawada.mshk@gmail.com>

View thread View on postgr.es
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Greg Nancarrow <gregn4422@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>, Alexey Lesovsky <lesovsky@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-11-15T09:17:34Z
Lists: pgsql-hackers

Attachments

On Mon, Nov 15, 2021 at 4:49 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Mon, Nov 15, 2021 at 1:49 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > I've attached an updated patch that incorporates all comments I got so
> > far. Please review it.
> >
>
> Thanks for the updated patch.
> A few minor comments:
>
> doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
>
> (1) tab in doc updates
>
> There's a tab before "Otherwise,":
>
> +        copy of the relation with <parameter>relid</parameter>.
>         Otherwise,

Fixed.

>
> src/backend/utils/adt/pgstatfuncs.c
>
> (2) The function comment for "pg_stat_reset_subscription_worker_sub"
> seems a bit long and I expected it to be multi-line (did you run
> pg_indent?)

I ran pg_indent on pgstatfuncs.c but it didn't become a multi-line comment.

>
> src/include/pgstat.h
>
> (3) Remove PgStat_StatSubWorkerEntry.dbid?
>
> The "dbid" member of the new PgStat_StatSubWorkerEntry struct doesn't
> seem to be used, so I think it should be removed.
> (I could remove it and everything builds OK and tests pass).
>

Fixed.

Thank you for the comments! I've updated an updated version patch.

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

Commits

  1. Test ALIGNOF_DOUBLE==4 compatibility under ALIGNOF_DOUBLE==8.

  2. Reorder subskiplsn in pg_subscription to avoid alignment issues.

  3. Add ALTER SUBSCRIPTION ... SKIP.

  4. Optionally disable subscriptions on error.

  5. Update docs of logical replication for commit 8d74fc96db.

  6. Respect permissions within logical replication.

  7. Fix regression test failure caused by commit 8d74fc96db.

  8. Add a view to show the stats of subscription workers.

  9. Add logical change details to logical replication worker errcontext.

  10. Rename LOGICAL_REP_MSG_STREAM_END to LOGICAL_REP_MSG_STREAM_STOP.

  11. Fix typo in protocol.sgml.

  12. Remove unused argument in apply_handle_commit_internal().

  13. Fix replication of in-progress transactions in tablesync worker.

  14. Reorder pg_sequence columns to avoid alignment issue