Horton
Menu

Re: speedup COPY TO for partitioned table.

Masahiko Sawada <sawada.mshk@gmail.com>

View thread
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: jian he <jian.universality@gmail.com>, torikoshia <torikoshia@oss.nttdata.com>, Kirill Reshke <reshkekirill@gmail.com>, vignesh C <vignesh21@gmail.com>, David Rowley <dgrowleyml@gmail.com>, Melih Mutlu <m.melihmutlu@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-10-13T17:43:22Z
Lists: pgsql-hackers 
On Fri, Oct 10, 2025 at 3:04 AM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Oct-10, jian he wrote:
>
> > On Fri, Oct 10, 2025 at 6:03 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> > > Yes, but I think it's more consistent given that we use the
> > > parentheses in all other places in copyto.c.
> >
> > If you look at tablecmds.c, like ATExecSetNotNull, there are
> > parentheses and no parentheses cases.
> > Overall, I think less parentheses improves readability and makes the
> > code more future-proof.
>
> I strive to remove those extra parentheses when I edit some part of the
> code (though I may forget at times), but leave them alone from other
> places that I'm not editing.  I don't add them in new code.  Most
> likely, this is why ATExecSetNotNull has some cases with them and other
> cases without.
>
> Given sufficient time, the Postgres of Theseus would eventually have
> zero of those extra parens.

Thank you for the input. I didn't know some files or functions already
have mixed style. I'll use this style for future changes.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Support COPY TO for partitioned tables.

  2. Re-implement the ereport() macro using __VA_ARGS__.