Remove unused fields in ReorderBufferTupleBuf
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-07-26T05:58:39Z
Lists: pgsql-hackers
Attachments
- v1-0001-Remove-unused-fields-in-ReorderBufferTupleBuf.patch (application/octet-stream) patch v1-0001
Hi,
ReorderBufferTupleBuf is defined as follow:
/* an individual tuple, stored in one chunk of memory */
typedef struct ReorderBufferTupleBuf
{
/* position in preallocated list */
slist_node node;
/* tuple header, the interesting bit for users of logical decoding */
HeapTupleData tuple;
/* pre-allocated size of tuple buffer, different from tuple size */
Size alloc_tuple_size;
/* actual tuple data follows */
} ReorderBufferTupleBuf;
However, node and alloc_tuple_size are not used at all. It seems an
oversight in commit a4ccc1cef5a, which introduced the generation
context and used it in logical decoding. I think we can remove them
(only on HEAD). I've attached the patch.
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
Commits
-
Remove ReorderBufferTupleBuf structure.
- 08e6344fd642 17.0 landed
-
Generational memory allocator
- a4ccc1cef5a0 11.0 cited