Re: maintenance_work_mem = 64kB doesn't work for vacuum

Masahiko Sawada <sawada.mshk@gmail.com>

From: Masahiko Sawada <sawada.mshk@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-03-18T06:34:01Z
Lists: pgsql-hackers

Attachments

On Mon, Mar 17, 2025 at 7:06 PM David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Tue, 18 Mar 2025 at 05:49, Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > I've attached the patch. I added the minimum regression tests for that.
>
> I think the change to vacuumlazy.c is ok. The new test you've added
> creates a table called pvactst2 but then adds a test that uses the
> pvactst table.

Fixed.

> Did you mean to skip the DROP TABLE pvactst2;?

Yes, added DROP TABLE pvactst2.

> Is there a reason to keep the maintenance_work_mem=64 for the
> subsequent existing test?

No, I reset it immediately after tests for pvactst2.

I've attached the updated patch.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Commits

  1. Fix assertion failure in parallel vacuum with minimal maintenance_work_mem setting.

  2. Lower minimum maintenance_work_mem to 64kB