Re: Inconsistent behavior of pg_dump/pg_restore on DEFAULT PRIVILEGES
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Neil Chen <carpenter.nail.cz@gmail.com>
Cc: "Boris P. Korzun" <drtr0jan@yandex.ru>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2021-10-14T00:36:55Z
Lists: pgsql-bugs, pgsql-hackers
Attachments
- fix-bug-on-dump-default-ACL_v2.patch (application/octet-stream) patch v2
Hi, On Fri, Oct 1, 2021 at 11:13 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > On Wed, Sep 22, 2021 at 10:31 AM Neil Chen <carpenter.nail.cz@gmail.com> wrote: > > > > Hi Boris, > > > > Actually, because I am a PG beginner, I am not familiar with the rules of the community. What extra work do I need to do to submit to the upstream? This bug discussion doesn't seem to see the concern of others. > > As far as I checked this bug still exists in all supported branches > (from 10 to 14, and HEAD). I'd recommend adding this patch to the next > commit fest so as not to forget, if not yet. > > I agree with your analysis on this bug. For non-default > (defaclnamespace != 0) entries, their acl should be compared to NULL. > > The fix also looks good to me. But I think it'd be better to add tests for this. Since the patch conflicts with the current HEAD, I've rebased and slightly updated the patch, adding the regression tests. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
Commits
-
pg_dump: fix mis-dumping of non-global default privileges.
- b1df061f704b 9.6.24 landed
- 871dfe4b7270 11.14 landed
- 52b927a731e5 12.9 landed
- 476006023538 13.5 landed
- 10f9faf6d873 10.19 landed
- 3ad2c2455be0 14.1 landed
- 2acc84c6fd29 15.0 landed