Horton
Menu

Re: BUG #18828: Crash when pg_get_logical_snapshot_meta() passed empty string

Masahiko Sawada <sawada.mshk@gmail.com>

View thread
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, tharakan@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2025-03-12T21:33:36Z
Lists: pgsql-bugs 
On Wed, Mar 12, 2025 at 12:03 PM Nathan Bossart
<nathandbossart@gmail.com> wrote:
>
> On Tue, Mar 11, 2025 at 03:34:18PM -0700, Masahiko Sawada wrote:
> > Pushed.
>
> I'm seeing warnings for the CI build on Windows [0] that appear to be
> related to this commit:
>
>         c:\cirrus\contrib\pg_logicalinspect\pg_logicalinspect.c(88) : warning C4715: 'parse_snapshot_filename': not all control paths return a value
>
> I suspect we just need to do something like commit fe4ecd0 and return
> InvalidXLogRecPtr after the ERROR.

Thank you for the report! David also reported the same issue[1]. I've
just pushed the fix.

BTW how did you catch the warning? I checked before the push if the
change had passed the CI tests (completed with green status). But when
checking the build log now, I can see the warning in the build logs.

Regards,

[1] https://www.postgresql.org/message-id/CAApHDvqrhFfnetbcwgGkJ=z63T8HfQ_OyP=vX8BYiXyxFKt67w@mail.gmail.com

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. pg_logicalinspect: Fix possible crash when passing a directory path.

  2. Add contrib/pg_logicalinspect.

  3. Fix compiler warning on Windows.