Re: Add mode column to pg_stat_progress_vacuum
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, Robert Treat <rob@xzilla.net>,
maciek@sakrejda.org, Nathan Bossart <nathandbossart@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-12-04T00:14:31Z
Lists: pgsql-hackers
Attachments
- fix_masahiko_v8.patch (application/octet-stream) patch v8
On Mon, Nov 24, 2025 at 6:06 PM Shinya Kato <shinya11.kato@gmail.com> wrote: > > On Tue, Nov 25, 2025 at 8:13 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > > What about “started_by” ? it’s unambiguous and consistent with other columns > > > like “query_start” in pg_stat_activity. > > > > "started_by" sounds reasonable to me. > > Thanks all. I've updated the patches to use "started_by" and replaced > remaining uses of "triggered" with "started". Thank you for updating the patches! I've attached a small change to simplify the 0001 patch. Please review it. For the 0002 patch adding "started_by" column to pg_stat_progress_analyze system view, while we can easily check that the analyze operation reported in pg_stat_progress_analyze is started manually or by autovacuum worker by joining it to pg_stat_activity on the pid column, the proposed column would help users to check it even easier. So +1. Here are a few comments: + <listitem> + <para> + <literal>manual</literal>: The analyze was started by an explicit For consistency with "started_by" in pg_stat_progress_vacuum, I think it's better to start with "The operation was started by". --- + <command>ANALYZE</command> or <command>VACUUM (ANALYZE)</command> + command. How about using "... or VACUUM with the ANALYZE option"? Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Add started_by column to pg_stat_progress_analyze view.
- ab40db3852df 19 (unreleased) landed
-
Add mode and started_by columns to pg_stat_progress_vacuum view.
- 0d7895206198 19 (unreleased) landed