Horton

Thread

Commits

  1. Use LW_SHARED in walsummarizer.c for WALSummarizerLock lock where possible.

  1. Use LW_SHARED in WakeupWalSummarizer() for WALSummarizerLock lock

    Masahiko Sawada <sawada.mshk@gmail.com> — 2025-08-25T22:38:13Z

    Hi all,

While reading walsummarizer.c code, I noticed that in
WakeupWalSummarizer() we acquire the WALSummarizerLock lock in
LW_EXCLUSIVE mode despite only reading
WalSummarizerCtl->summarizer_pgprocno. The attached patch uses
LW_SHARED mode instead. Feedback is very welcome.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

  2. Re: Use LW_SHARED in WakeupWalSummarizer() for WALSummarizerLock lock

    Nathan Bossart <nathandbossart@gmail.com> — 2025-08-26T00:08:15Z

    On Mon, Aug 25, 2025 at 03:38:13PM -0700, Masahiko Sawada wrote:
> While reading walsummarizer.c code, I noticed that in
> WakeupWalSummarizer() we acquire the WALSummarizerLock lock in
> LW_EXCLUSIVE mode despite only reading
> WalSummarizerCtl->summarizer_pgprocno. The attached patch uses
> LW_SHARED mode instead. Feedback is very welcome.

You could probably do something similar for WaitForWalSummarization().

-- 
nathan

  3. Re: Use LW_SHARED in WakeupWalSummarizer() for WALSummarizerLock lock

    Masahiko Sawada <sawada.mshk@gmail.com> — 2025-08-26T00:48:49Z

    On Mon, Aug 25, 2025 at 5:08 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Mon, Aug 25, 2025 at 03:38:13PM -0700, Masahiko Sawada wrote:
> > While reading walsummarizer.c code, I noticed that in
> > WakeupWalSummarizer() we acquire the WALSummarizerLock lock in
> > LW_EXCLUSIVE mode despite only reading
> > WalSummarizerCtl->summarizer_pgprocno. The attached patch uses
> > LW_SHARED mode instead. Feedback is very welcome.
>
> You could probably do something similar for WaitForWalSummarization().

Good point. I've attached the updated patch.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

  4. Re: Use LW_SHARED in WakeupWalSummarizer() for WALSummarizerLock lock

    Masahiko Sawada <sawada.mshk@gmail.com> — 2025-08-29T18:47:44Z

    On Mon, Aug 25, 2025 at 5:48 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Mon, Aug 25, 2025 at 5:08 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
> >
> > On Mon, Aug 25, 2025 at 03:38:13PM -0700, Masahiko Sawada wrote:
> > > While reading walsummarizer.c code, I noticed that in
> > > WakeupWalSummarizer() we acquire the WALSummarizerLock lock in
> > > LW_EXCLUSIVE mode despite only reading
> > > WalSummarizerCtl->summarizer_pgprocno. The attached patch uses
> > > LW_SHARED mode instead. Feedback is very welcome.
> >
> > You could probably do something similar for WaitForWalSummarization().
>
> Good point. I've attached the updated patch.

Pushed.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com