Re: print_path is missing GatherMerge and CustomScan support
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>,
Robert Haas <robertmhaas@gmail.com>, Ashutosh Bapat <ashutosh.bapat@gmail.com>
Date: 2018-07-19T09:38:00Z
Lists: pgsql-hackers
On Thu, Jul 19, 2018 at 9:58 AM, Michael Paquier <michael@paquier.xyz> wrote: > On Wed, Jul 18, 2018 at 03:22:02PM +0900, Michael Paquier wrote: >> Good catch. Those should be backpatched. While I am looking at this >> stuff, I have noticed that pathnode.c/reparameterize_path_by_child uses >> T_MergeAppend and not T_MergeAppendPath. > > Okay, I have checked the full list of path nodes and the two ones you > mentioned are the only missing. CustomPath has been added in 9.5, so > this has been patched down to this version. GatherMergePath is new as > of 10. > > The order of the items in print_path and nodes.h was a bit messed up as > well which made unnecessarily harder to check the list, so I fixed the > order at the same time to ease future lookups and back-patching effort. Thank you for committing the patch! Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
Commits
-
Fix print of Path nodes when using OPTIMIZER_DEBUG
- 3ecd6c4ab9dd 9.5.14 landed
- 164ed1532f78 9.6.10 landed
- 49d506dd2162 10.5 landed
- bc62aef53d68 11.0 landed
- b33ef397a169 12.0 landed
-
Fix re-parameterize of MergeAppendPath
- 6365ebacdd08 11.0 landed
- c6598b8b0514 12.0 landed