Add the replication origin name and commit-LSN to logical replication worker errcontext
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-02-28T12:15:23Z
Lists: pgsql-hackers
Attachments
- 0002-Add-the-origin-name-and-remote-commit-LSN-to-logical.patch (application/x-patch) patch 0002
- 0001-Use-complete-sentences-in-logical-replication-worker.patch (application/x-patch) patch 0001
Hia, We've added some information such as the command and the timestamp to the error context message by commit abc0910e2. This patch adds further information to it: replication origin name and commit-LSN. This will be helpful for users to set the origin name and LSN to pg_replication_origin_advance(). The errcontext message would become like follows: *Before ERROR: duplicate key value violates unique constraint "test_pkey" DETAIL: Key (c)=(1) already exists. CONTEXT: processing remote data during "INSERT" for replication target relation "public.test" in transaction 726 at 2022-02-28 20:59:56.005909+09 * After ERROR: duplicate key value violates unique constraint "test_pkey" DETAIL: Key (c)=(1) already exists. CONTEXT: processing remote data during "INSERT" for replication target relation "public.test" in transaction 726 committed at LSN 0/14BFA88 and timestamp 2022-02-28 20:58:27.964238+09 from replication origin "pg_16395" I'm a bit concerned that the message may be too long. I've attached two patches: the first one changes apply_error_callback() so that it uses complete sentences with if-else blocks in order to have a translation work, the second patch adds the origin name and commit-LSN to the errcontext message. Regards, -- Masahiko Sawada EDB: https://www.enterprisedb.com/
Commits
-
Add the additional information to the logical replication worker errcontext.
- d3e8368c4b6e 15.0 landed
-
Make the errcontext message in logical replication worker translation friendly.
- 5e0e99a80b2f 15.0 landed
-
Add logical change details to logical replication worker errcontext.
- abc0910e2e0a 15.0 cited