Horton
Menu

Re: Add mode column to pg_stat_progress_vacuum

Masahiko Sawada <sawada.mshk@gmail.com>

View thread
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Shinya Kato <shinya11.kato@gmail.com>
Cc: Sami Imseih <samimseih@gmail.com>, Robert Treat <rob@xzilla.net>, maciek@sakrejda.org, Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-12-08T21:25:11Z
Lists: pgsql-hackers 
On Thu, Dec 4, 2025 at 8:30 PM Shinya Kato <shinya11.kato@gmail.com> wrote:
>
> Thank you for the review!
>
> On Thu, Dec 4, 2025 at 9:15 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > I've attached a small change to simplify the 0001 patch. Please review it.
>
> LGTM, and I've updated in v9 patches.
>
> > Here are a few comments:
> >
> > +        <listitem>
> > +         <para>
> > +          <literal>manual</literal>: The analyze was started by an explicit
> >
> > For consistency with "started_by" in pg_stat_progress_vacuum, I think
> > it's better to start with "The operation was started by".
>
> I think "started_by" in pg_stat_progress_vacuum uses "The vacuum was
> started by ...".

I missed that, you're right.

>
> > ---
> > +          <command>ANALYZE</command> or <command>VACUUM (ANALYZE)</command>
> > +          command.
> >
> > How about using "... or VACUUM with the ANALYZE option"?
>
> Agreed, I've fixed it.

Thank you for updating the patch!

The patches look good to me, so I'm going to push them if there are
not further review comments and objections.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add started_by column to pg_stat_progress_analyze view.

  2. Add mode and started_by columns to pg_stat_progress_vacuum view.