Re: when set track_commit_timestamp on, database system abort startup

Masahiko Sawada <sawada.mshk@gmail.com>

From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>, Alvaro Herrera <alvherre@2ndquadrant.com>, 李海龙 <hailong.li@qunar.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2018-09-27T09:18:41Z
Lists: pgsql-hackers
On Wed, Sep 26, 2018 at 10:34 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Sep 25, 2018 at 11:54:53PM +0900, Masahiko Sawada wrote:
> > Can we use "XLOG_PARAMETER_CHANGE record" instead of  "record
> > XLOG_PARAMETER_CHANGE" at the second hunk because the comment of the
> > first hunk uses it. The other part of this patch looks good to me.
>
> Let's use your suggestion, and committed down to 9.5 where this fix
> applies.  The TAP test is only present in v11 and above.  I have also
> noticed some comment which became incorrect after the fix, so I changed
> them on the way.

Thank you!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


Commits

  1. Rework activation of commit timestamps during recovery