Re: Report the number of skipped frozen pages by manual VACUUM
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Jim Nasby <jim.nasby@openscg.com>
Cc: Yugo Nagata <nagata@sraoss.co.jp>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-03-10T11:08:42Z
Lists: pgsql-hackers
Attachments
- report_frozen_skipped_pages_v3.patch (application/octet-stream) patch v3
On Fri, Mar 10, 2017 at 3:58 PM, Jim Nasby <jim.nasby@openscg.com> wrote: > On 3/6/17 8:34 PM, Masahiko Sawada wrote: >> >> I don't think it can say "1 frozen pages" because the number of >> skipped pages according to visibility map is always more than 32 >> (SKIP_PAGES_THRESHOLD). > > > That's just an artifact of how the VM currently works. I'm not a fan of > cross dependencies like that unless there's a pretty good reason. Thank you for the comment. Agreed. Attached fixed version patch. > BTW, I think there's already a function that handles the pluralization for > you. IIRC it's one of the things you can add to an ereport() call. What is the function name? Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
Commits
-
Make VACUUM VERBOSE report the number of skipped frozen pages.
- 70adf2fbe18f 10.0 landed
-
Allow vacuums to report oldestxmin
- 9eb344faf54a 10.0 cited