Re: UUID v7
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>,
Peter Eisentraut <peter@eisentraut.org>
Cc: Jelte Fennema-Nio <postgres@jeltef.nl>, Sergey Prokhorenko <sergeyprokhorenko@yahoo.com.au>, Przemysław Sztoch <przemyslaw@sztoch.pl>, Michael Paquier <michael@paquier.xyz>, Aleksander Alekseev <aleksander@timescale.com>, pgsql-hackers mailing list <pgsql-hackers@postgresql.org>, "David G. Johnston" <david.g.johnston@gmail.com>, Mat Arye <mat@timescaledb.com>, Matthias van de Meent <boekewurm+postgres@gmail.com>, Nikolay Samokhvalov <samokhvalov@gmail.com>, Junwang Zhao <zhjwpku@gmail.com>, Stepan Neretin <sncfmgg@gmail.com>
Date: 2024-11-27T18:24:01Z
Lists: pgsql-hackers
On Tue, Nov 26, 2024 at 7:11 PM Andrey Borodin <x4mmm@yandex-team.ru> wrote: > > > > > On 27 Nov 2024, at 04:11, Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > > > On Tue, Nov 26, 2024 at 1:55 PM Jelte Fennema-Nio <postgres@jeltef.nl> wrote: > >> > >> On Tue, 26 Nov 2024 at 21:48, Sergey Prokhorenko > >> <sergeyprokhorenko@yahoo.com.au> wrote: > >>> gen_uuidv7() is OK > >> > >> I'd very much prefer to not have a gen_ or get_ prefix as argued before[1][2]. > >> > >> My vote is still for simply uuidv7() and uuidv4() > >> > >>> uuid-ossp is outdated, slow and not supported by the author. UUIDv7 is the renaissance of UUIDs. So we should not depend on legacy technology names > >> > >> agreed > >> > > > > It seems that we agreed to use 'uuidv7' instead of 'uuid_v7()'. There > > is discussion whether we should add 'gen_' or 'get_' but let's go back > > to the previously-agreed function name 'uuidv7()' for now. We can > > rename it later if we find a better name. > > I think uuidv7() is kind of consensual. > > > I've attached the new version patch that incorporated all comments and > > renamed the functions. Also I avoided using 'if defined(__darwin__) || > > defined(_MSC_VER)' twice. > > Good, I think now it's a bit easier to understand those 2 bits. > Thanks. I'm going to push the v39 patch (after self review again), barring any objections and further comments. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
Commits
-
Fix timestamp overflow in UUIDv7 implementation.
- a5419bc72e22 18.0 landed
-
Add UUID version 7 generation function.
- 78c5e141e9c1 18.0 landed
-
Add some UUID support functions
- 794f10f6b920 17.0 landed