Horton

Re: Add contrib/pg_logicalsnapinspect

Masahiko Sawada <sawada.mshk@gmail.com>

View thread
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Euler Taveira <euler@eulerto.com>
Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Andres Freund <andres@anarazel.de>, Peter Smith <smithpb2250@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, "shveta.malik@gmail.com" <shveta.malik@gmail.com>, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2025-03-16T05:39:48Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix indentation issue

  2. pg_logicalinspect: Stabilize isolation tests.

  3. Add contrib/pg_logicalinspect.

  4. Move SnapBuild and SnapBuildOnDisk structs to snapshot_internal.h.

On Thu, Mar 13, 2025 at 6:20 PM Euler Taveira <euler@eulerto.com> wrote:
>
> On Tue, Mar 11, 2025, at 7:34 PM, Masahiko Sawada wrote:
>
> Pushed.
>
>
> pgindent is saying this commit included some extra tabs.
>
> git diff
> diff --git a/contrib/pg_logicalinspect/pg_logicalinspect.c b/contrib/pg_logicalinspect/pg_logicalinspect.c
> index ff6c682679f..5a44718bea8 100644
> --- a/contrib/pg_logicalinspect/pg_logicalinspect.c
> +++ b/contrib/pg_logicalinspect/pg_logicalinspect.c
> @@ -86,7 +86,7 @@ parse_error:
>     ereport(ERROR,
>             errmsg("invalid snapshot file name \"%s\"", filename));
>
> -   return InvalidXLogRecPtr;                   /* keep compiler quiet */
> +   return InvalidXLogRecPtr;   /* keep compiler quiet */
> }

Yes, David fixed it in commit b955df44340.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com