Re: Berserk Autovacuum (let's save next Mandrill)
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Darafei Komяpa Praliaskouski <me@komzpa.net>, Alvaro Herrera <alvherre@2ndquadrant.com>, PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-28T10:28:27Z
Lists: pgsql-hackers
On Thu, Mar 28, 2019 at 6:32 PM David Rowley <david.rowley@2ndquadrant.com> wrote: > > On Thu, 28 Mar 2019 at 22:04, Darafei "Komяpa" Praliaskouski > <me@komzpa.net> wrote: > > > > On Thu, Mar 28, 2019 at 2:36 AM David Rowley <david.rowley@2ndquadrant.com> wrote: > >> I thought recently that it would be good to have some sort of > >> pro-active auto-vacuum mode that made use of idle workers. > > > > Problem with "idle" is that it never happens on system that are going to wraparound on their lifetime. This has to be a part of normal database functioning. > > I'd say auto-vacuum is configured to run too slowly if you never have > an idle worker. The chances that it happens to be running at exactly > the right speed to keep up with demand must be about close to nil. > > > Why not select a table that has inserts, updates and deletes for autovacuum just like we do for autoanalyze, not only deletes and updates like we do now? > > Sounds like a good idea, although I do agree with Alvaro when he > mentions that it would be good to only invoke a worker that was only > going to freeze tuples and not look at the indexes. The invoking autovacuum on table based on inserts, not only deletes and updates, seems good idea to me. But in this case, I think that we can not only freeze tuples but also update visibility map even when setting all-visible. Roughly speaking I think vacuum does the following operations. 1. heap vacuum 2. HOT pruning 3. freezing tuples 4. updating visibility map (all-visible and all-frozen) 5. index vacuum/cleanup 6. truncation With the proposed patch[1] we can control to do 5 or not. In addition to that, another proposed patch[2] allows us to control 6. For append-only tables (and similar tables), what we periodically want to do would be 3 and 4 (possibly we can do 2 as well). So maybe we need to have both an option of (auto)vacuum to control whether to do 1 and something like a new autovacuum threshold (or an option) to invoke the vacuum that disables 1, 5 and 6. The vacuum that does only 2, 3 and 4 would be much cheaper than today's vacuum and anti-wraparound vacuum would be able to skip almost pages. [1] https://commitfest.postgresql.org/22/1817/ [2] https://commitfest.postgresql.org/22/1981/ Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
Commits
-
Further improve stability fix for partition_aggregate test.
- 18d85e9b8a2b 13.0 landed
-
Improve stability fix for partition_aggregate test.
- 7cb0a423f914 13.0 landed
-
Attempt to stabilize partitionwise_aggregate test
- cefb82d49e21 13.0 landed
-
Fix race condition in statext_store().
- fe3036527a1f 13.0 landed
- 6c426cd43790 12.3 landed
-
Attempt to fix unstable regression tests, take 2
- 24566b359d09 13.0 landed
-
Attempt to fix unstable regression tests
- 2dc16efedc76 13.0 landed
-
Trigger autovacuum based on number of INSERTs
- b07642dbcd8d 13.0 landed
-
Fix upper limit for vacuum_cleanup_index_scale_factor
- 4d54543efa5e 11.0 cited