Horton

Re: Issue with pg_stat_subscription_stats

Masahiko Sawada <sawada.mshk@gmail.com>

View thread View on postgr.es
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Melanie Plageman <melanieplageman@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2022-07-06T02:41:46Z
Lists: pgsql-hackers

Attachments

On Wed, Jul 6, 2022 at 10:48 AM Andres Freund <andres@anarazel.de> wrote:
>
> On 2022-07-06 10:25:02 +0900, Masahiko Sawada wrote:
> > > I think most of this could just be pgstat_reset_entry().
> >
> > I think pgstat_reset_entry() doesn't work for this case as it skips
> > resetting the entry if it doesn't exist.
>
> True - but a pgstat_get_entry_ref(create = true); pgstat_reset_entry(); would
> still be shorter?

Indeed. I've updated the patch.

Regards,

--
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

Commits

  1. Create subscription stats entry at CREATE SUBSCRIPTION time

  2. pgstat: drop subscription stats without slot as well, fix comment

  3. pgstat: drop subscription stats regardless of slot, fix comment