RepOrigin vs. replorigin
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-01-26T21:24:27Z
Lists: pgsql-hackers
Hi all,
While reading the code in origin.c, I found the inconsistent use of
RepOrigin and replorigin (with an 'l') quite confusing -- especially
when trying to determine names for new functions or variables. For
instance,
- RepOriginId
- InvalidRepOriginId
- RM_REPLORIGIN_ID
- XLOG_REPLORIGIN_{SET|DROP}
- replorigin_session_origin
- replorigin_session_xxx() functions
Is there a conventional rule for choosing one over the other depending
on context? Or should we consider unifying these naming conventions?"
Regards,
--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com
Commits
-
Standardize replication origin naming to use "ReplOrigin".
- 1fdbca159e00 19 (unreleased) landed