Horton

Thread

Commits

  1. Replace magic constants used in pg_stat_get_replication_slot().

  1. Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()

    Masahiko Sawada <sawada.mshk@gmail.com> — 2021-06-29T11:41:34Z

    Hi all,

I realized that we use the magic number 10 instead of
PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
function. It seems an oversight of the original commit. Attached patch
fixes it.

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

  2. Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()

    Amit Kapila <amit.kapila16@gmail.com> — 2021-06-29T12:37:30Z

    On Tue, Jun 29, 2021 at 5:12 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> Hi all,
>
> I realized that we use the magic number 10 instead of
> PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
> function. It seems an oversight of the original commit. Attached patch
> fixes it.
>

LGTM. I'll take care of it tomorrow.

-- 
With Regards,
Amit Kapila.

  3. Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()

    Amit Kapila <amit.kapila16@gmail.com> — 2021-06-30T08:12:37Z

    On Tue, Jun 29, 2021 at 6:07 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Jun 29, 2021 at 5:12 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > Hi all,
> >
> > I realized that we use the magic number 10 instead of
> > PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
> > function. It seems an oversight of the original commit. Attached patch
> > fixes it.
> >
>
> LGTM. I'll take care of it tomorrow.
>

Pushed.


-- 
With Regards,
Amit Kapila.

  4. Re: Use PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()

    Masahiko Sawada <sawada.mshk@gmail.com> — 2021-06-30T11:48:14Z

    On Wed, Jun 30, 2021 at 5:12 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Jun 29, 2021 at 6:07 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Tue, Jun 29, 2021 at 5:12 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > >
> > > Hi all,
> > >
> > > I realized that we use the magic number 10 instead of
> > > PG_STAT_GET_REPLICATION_SLOT_COLS in pg_stat_get_replication_slot()
> > > function. It seems an oversight of the original commit. Attached patch
> > > fixes it.
> > >
> >
> > LGTM. I'll take care of it tomorrow.
> >
>
> Pushed.

Thanks!

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/