Re: pg_stop_backup(wait_for_archive := true) on standby server
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Michael Paquier <michael.paquier@gmail.com>,
Robert Haas <robertmhaas@gmail.com>, Noah Misch <noah@leadboat.com>,
Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Magnus Hagander <magnus@hagander.net>,
PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-08-04T02:56:47Z
Lists: pgsql-hackers
On Fri, Aug 4, 2017 at 10:48 AM, Stephen Frost <sfrost@snowman.net> wrote: > Michael, > > * Michael Paquier (michael.paquier@gmail.com) wrote: >> On Wed, Aug 2, 2017 at 7:58 PM, Stephen Frost <sfrost@snowman.net> wrote: >> > * Michael Paquier (michael.paquier@gmail.com) wrote: >> >> Do you need a back-patchable version for 9.6? I could get one out of >> >> my pocket if necessary. >> > >> > I was just trying to find a bit of time to generate exactly that- if >> > you have a couple spare cycles, it would certainly help. >> >> OK, here you go. Even if archive_mode = always has been introduced in >> 9.5, but non-exclusive mode is a 9.6 feature, so here are patches down >> to this version. I am pretty satisfied by this, and I included all the >> comments and error message corrections reviewed up to now. I noticed >> some incorrect comments, doc typos and an incorrect indentation as >> well for the WARNING reported to the user when waiting for the >> archiving. > > Thanks much for this. I've looked over it some and it looks pretty good > to me. I'm going to play with it a bit more and, barring issues, will > push them tomorrow morning. > Thank you for the patches, Michael-san! It looks good to me too. Regards, -- Masahiko Sawada NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center
Commits
-
Make pg_stop_backup's wait_for_archive flag work on standbys.
- 52f8a59dd953 10.0 landed
-
Implement backup API functions for non-exclusive backups
- 7117685461af 9.6.0 cited