Horton

Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c

Masahiko Sawada <sawada.mshk@gmail.com>

View thread
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>, kristianlejao@gmail.com
Date: 2025-08-07T17:29:41Z
Lists: pgsql-bugs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix EvalPlanQual handling of foreign/custom joins in ExecScanFetch.

On Wed, Aug 6, 2025 at 8:39 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Aug 05, 2025 at 11:00:54AM -0700, Masahiko Sawada wrote:
> > The attached patch includes the draft fix and regression tests (using
> > injection points).
>
> +$psql_session->query_safe(qq[
> +    select injection_points_set_local();
> +    select injection_points_attach('heapam_lock_tuple-before-lock', 'wait');
> +]);
>
> It seems to me that an isolation test would be a better fit here.  TAP
> tests are usually a good fit for injection points if you need to do
> direct node manipulations, like restarts or stops.  The whole test
> posted only does SQL-ish things, and you could rely on a loopback
> server as we do in the SQL tests of postgres_fdw?

Yes, it's definitely possible to create the test using isolation. I
wasn't sure how to invoke isolation tests only when injection points
are enabled.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com