Re: Skipping logical replication transactions on subscriber side

Masahiko Sawada <sawada.mshk@gmail.com>

From: Masahiko Sawada <sawada.mshk@gmail.com>

To: Greg Nancarrow <gregn4422@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>, Alexey Lesovsky <lesovsky@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-10-18T01:34:22Z

Lists: pgsql-hackers

Attachments

v17-0003-Add-skip_xid-option-to-ALTER-SUBSCRIPTION.patch (application/octet-stream) patch v17-0003
v17-0002-Add-RESET-command-to-ALTER-SUBSCRIPTION-command.patch (application/octet-stream) patch v17-0002
v17-0001-Add-a-subscription-errors-statistics-view-pg_sta.patch (application/octet-stream) patch v17-0001

On Thu, Oct 14, 2021 at 5:45 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Tue, Oct 12, 2021 at 4:00 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > I've attached updated patches.
> >
>
> A couple more comments for some issues that I noticed in the v16 patches:
>
> v16-0002
>
> doc/src/sgml/ref/alter_subscription.sgml
>
> (1) Order of parameters that can be reset doesn't match those that can be set.
> Also, it doesn't match the order specified in the documentation
> updates in the v16-0003 patch.
>
> Suggested change:
>
> BEFORE:
> +       The parameters that can be reset are: <literal>streaming</literal>,
> +       <literal>binary</literal>, <literal>synchronous_commit</literal>.
> AFTER:
> +       The parameters that can be reset are:
> <literal>synchronous_commit</literal>,
> +       <literal>binary</literal>, <literal>streaming</literal>.
>

Fixed.

>
> v16-0003
>
> doc/src/sgml/ref/alter_subscription.sgml
>
> (1) Documentation update says "slot_name" is a parameter that can be
> reset, but this is not correct, it can't be reset.
> Also, the doc update is missing "the" before "parameter".
>
> Suggested change:
>
> BEFORE:
> +      The parameters that can be reset are: <literal>slot_name</literal>,
> +      <literal>synchronous_commit</literal>, <literal>binary</literal>,
> +      <literal>streaming</literal>, and following parameter:
> AFTER:
> +      The parameters that can be reset are:
> <literal>synchronous_commit</literal>,
> +      <literal>binary</literal>, <literal>streaming</literal>, and
> the following
> +      parameter:

Fixed.

I've attached updated patches that incorporate all comments I got so far.

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

Commits

Test ALIGNOF_DOUBLE==4 compatibility under ALIGNOF_DOUBLE==8.
- c1da0acbb06e 15.0 landed
Reorder subskiplsn in pg_subscription to avoid alignment issues.
- 79b716cfb7a1 15.0 landed
Add ALTER SUBSCRIPTION ... SKIP.
- 208c5d65bbd6 15.0 landed
Optionally disable subscriptions on error.
- 705e20f8550c 15.0 cited
Update docs of logical replication for commit 8d74fc96db.
- 85c61ba8920b 15.0 landed
Respect permissions within logical replication.
- a2ab9c06ea15 15.0 cited
Fix regression test failure caused by commit 8d74fc96db.
- 41e66fee0516 15.0 landed
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 landed
Add logical change details to logical replication worker errcontext.
- abc0910e2e0a 15.0 landed
Rename LOGICAL_REP_MSG_STREAM_END to LOGICAL_REP_MSG_STREAM_STOP.
- 4cd7a1896871 15.0 landed
Fix typo in protocol.sgml.
- e1915646658d 14.0 landed
- 0ac1aee0d7d8 15.0 landed
Remove unused argument in apply_handle_commit_internal().
- f4b939f1a372 14.0 landed
- 16bd4becee32 15.0 landed
Fix replication of in-progress transactions in tablesync worker.
- 0926e96c4934 14.0 cited
Reorder pg_sequence columns to avoid alignment issue
- f3b421da5f4a 10.0 cited