Horton

Re: Inconsistent LSN format in pg_waldump output

Masahiko Sawada <sawada.mshk@gmail.com>

View thread View on postgr.es
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Japin Li <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-07-05T14:01:52Z
Lists: pgsql-hackers 
On Fri, Jul 4, 2025 at 8:01 PM Álvaro Herrera <alvherre@kurilemu.de> wrote:
>
> On 2025-Jul-04, Japin Li wrote:
>
> > I've opted to directly use %X/%08X for LSN formatting in this patch, with an
> > accompanying comment near LSN_FORMAT_ARGS.
>
> Thank you!  I support this approach and intend to work on getting this
> patch committed soon after some more review, unless there are further
> objections.

+1. I think we need to update LSN values in the documentation too.

Regards,

-- 
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

Commits

  1. Fix a couple more places in docs for pg_lsn change

  2. Adapt pg_upgrade test to pg_lsn output format difference

  3. Standardize LSN formatting by zero padding