Re: Skipping logical replication transactions on subscriber side

Masahiko Sawada <sawada.mshk@gmail.com>

From: Masahiko Sawada <sawada.mshk@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: Greg Nancarrow <gregn4422@gmail.com>, "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Alexey Lesovsky <lesovsky@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-08-23T03:09:21Z

Lists: pgsql-hackers

Attachments

v10-0005-Move-shared-fileset-cleanup-to-before_shmem_exit.patch (application/octet-stream) patch v10-0005
v10-0001-Add-logical-changes-details-to-errcontext-of-app.patch (application/octet-stream) patch v10-0001
v10-0003-Add-RESET-command-to-ALTER-SUBSCRIPTION-command.patch (application/octet-stream) patch v10-0003
v10-0004-Add-skip_xid-option-to-ALTER-SUBSCRIPTION.patch (application/octet-stream) patch v10-0004
v10-0002-Add-pg_stat_subscription_errors-statistics-view.patch (application/octet-stream) patch v10-0002

On Thu, Aug 19, 2021 at 10:09 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Thu, Aug 19, 2021 at 9:14 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Thu, Aug 19, 2021 at 12:47 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > >
> > > On Tue, Aug 17, 2021 at 12:00 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
> > > >
> > >
> > > > Another comment on the 0001 patch: as there is now a mix of setting
> > > > "apply_error_callback_arg" members directly and also through inline
> > > > functions, it might look better to have it done consistently with
> > > > functions having prototypes something like the following:
> > > >
> > > > static inline void set_apply_error_context_rel(LogicalRepRelMapEntry *rel);
> > > > static inline void reset_apply_error_context_rel(void);
> > > > static inline void set_apply_error_context_attnum(int remote_attnum);
> > >
> > > It might look consistent, but if we do that, we will end up needing
> > > functions every field to update when we add new fields to the struct
> > > in the future?
> > >
> >
> > Yeah, I also think it is too much, but we can add comments where ever
> > we set the information for error callback. I see it is missing when
> > the patch is setting remote_attnum, see similar other places and add
> > comments if already not there.
>
> Agred. Will add comments in the next version patch.

I've attached updated patches. Please review them.

Regards,

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

Commits

Test ALIGNOF_DOUBLE==4 compatibility under ALIGNOF_DOUBLE==8.
- c1da0acbb06e 15.0 landed
Reorder subskiplsn in pg_subscription to avoid alignment issues.
- 79b716cfb7a1 15.0 landed
Add ALTER SUBSCRIPTION ... SKIP.
- 208c5d65bbd6 15.0 landed
Optionally disable subscriptions on error.
- 705e20f8550c 15.0 cited
Update docs of logical replication for commit 8d74fc96db.
- 85c61ba8920b 15.0 landed
Respect permissions within logical replication.
- a2ab9c06ea15 15.0 cited
Fix regression test failure caused by commit 8d74fc96db.
- 41e66fee0516 15.0 landed
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 landed
Add logical change details to logical replication worker errcontext.
- abc0910e2e0a 15.0 landed
Rename LOGICAL_REP_MSG_STREAM_END to LOGICAL_REP_MSG_STREAM_STOP.
- 4cd7a1896871 15.0 landed
Fix typo in protocol.sgml.
- e1915646658d 14.0 landed
- 0ac1aee0d7d8 15.0 landed
Remove unused argument in apply_handle_commit_internal().
- f4b939f1a372 14.0 landed
- 16bd4becee32 15.0 landed
Fix replication of in-progress transactions in tablesync worker.
- 0926e96c4934 14.0 cited
Reorder pg_sequence columns to avoid alignment issue
- f3b421da5f4a 10.0 cited