Horton

Re: doc: pg_trgm missing description for GUC "pg_trgm.strict_word_similarity_threshold"

Masahiko Sawada <sawada.mshk@gmail.com>

View thread View on postgr.es
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Ian Barwick <ian.barwick@2ndquadrant.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Alexander Korotkov <a.korotkov@postgrespro.ru>
Date: 2019-06-07T06:44:14Z
Lists: pgsql-hackers 
On Thu, Jun 6, 2019 at 10:19 PM Ian Barwick <ian.barwick@2ndquadrant.com> wrote:
>
> Hi
>
> Commit be8a7a68662 added custom GUC "pg_trgm.strict_word_similarity_threshold",
> but omitted to document this in the section "GUC Parameters";

Indeed.

BTW while looking GUC variables defined in trgm_op.c the operators in
each short description seems not correct; there is an extra percent
sign. Should we also fix them?

postgres(1:43133)=# select name, short_desc from pg_settings where
name like 'pg_trgm%';
                   name                   |                  short_desc
------------------------------------------+-----------------------------------------------
 pg_trgm.similarity_threshold             | Sets the threshold used by
the %% operator.
 pg_trgm.strict_word_similarity_threshold | Sets the threshold used by
the <<%% operator.
 pg_trgm.word_similarity_threshold        | Sets the threshold used by
the <%% operator.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Commits

  1. Remove pg_trgm.strict_word_similarity_threshold doc from 9.6 and 10

  2. Add docs of missing GUC to pgtrgm.sgml

  3. Fix docs indentation in pgtrgm.sgml

  4. Fix operator naming in pg_trgm GUC option descriptions

  5. Add strict_word_similarity to pg_trgm module