Horton

Thread

Commits

  1. Fix typo in AutoVacLauncherMain().

  1. Fix a typo of comments in AutoVacLauncherMain

    Yugo Nagata <nagata@sraoss.co.jp> — 2025-08-01T15:20:27Z

    Hi,

While reading autovacuum.c, I found the following comments in
AutoVacLauncherMain() right before the call to rebuild_database_list();

         * Create the initial database list.  The invariant we want this list to
         * keep is that it's ordered by decreasing next_time.  As soon as an entry

However, I couldn't fnd any variable named "next_time". I believe it actually refers
to adl_next_worker and the comments should use "next_worker" as is done in other nereby
comments. I've attahed a patch to address this.

Regards,
Yugo Nagata


-- 
Yugo Nagata <nagata@sraoss.co.jp>

  2. Re: Fix a typo of comments in AutoVacLauncherMain

    Masahiko Sawada <sawada.mshk@gmail.com> — 2025-08-01T17:00:48Z

    On Fri, Aug 1, 2025 at 8:20 AM Yugo Nagata <nagata@sraoss.co.jp> wrote:
>
> Hi,
>
> While reading autovacuum.c, I found the following comments in
> AutoVacLauncherMain() right before the call to rebuild_database_list();
>
>          * Create the initial database list.  The invariant we want this list to
>          * keep is that it's ordered by decreasing next_time.  As soon as an entry
>
> However, I couldn't fnd any variable named "next_time". I believe it actually refers
> to adl_next_worker and the comments should use "next_worker" as is done in other nereby
> comments. I've attahed a patch to address this.
>

I agree with your analysis. WIll push the patch shortly, barring any objections.

Regards,

--
Masahiko Sawada
Amazon Web Services: https://aws.amazon.com

  3. Re: Fix a typo of comments in AutoVacLauncherMain

    Yugo Nagata <nagata@sraoss.co.jp> — 2025-08-04T01:03:38Z

    On Fri, 1 Aug 2025 10:00:48 -0700
Masahiko Sawada <sawada.mshk@gmail.com> wrote:

> On Fri, Aug 1, 2025 at 8:20 AM Yugo Nagata <nagata@sraoss.co.jp> wrote:
> >
> > Hi,
> >
> > While reading autovacuum.c, I found the following comments in
> > AutoVacLauncherMain() right before the call to rebuild_database_list();
> >
> >          * Create the initial database list.  The invariant we want this list to
> >          * keep is that it's ordered by decreasing next_time.  As soon as an entry
> >
> > However, I couldn't fnd any variable named "next_time". I believe it actually refers
> > to adl_next_worker and the comments should use "next_worker" as is done in other nereby
> > comments. I've attahed a patch to address this.
> >
> 
> I agree with your analysis. WIll push the patch shortly, barring any objections.

Thank you!

Yugo Nagata
Regards,


-- 
Yugo Nagata <nagata@sraoss.co.jp>