Horton

Thread

Commits

  1. Fix documentation of ALTER TABLE for stored values

  1. Missing generated column in ALTER TABLE ADD COLUMN doc

    Masahiko Sawada <sawada.mshk@gmail.com> — 2019-06-07T09:07:34Z

    Hi,

We support ALTER TABLE ADD COLUMN .. GENERATED ALWAYS AS .. but the
doc is missing it. Attached small patch fixes this.

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  2. Re: Missing generated column in ALTER TABLE ADD COLUMN doc

    Michael Paquier <michael@paquier.xyz> — 2019-06-10T08:05:04Z

    On Fri, Jun 07, 2019 at 06:07:34PM +0900, Masahiko Sawada wrote:
> We support ALTER TABLE ADD COLUMN .. GENERATED ALWAYS AS .. but the
> doc is missing it. Attached small patch fixes this.

Your patch updates the section related to constraint_name.  Don't you
need an extra line for the "action" part?
--
Michael

  3. Re: Missing generated column in ALTER TABLE ADD COLUMN doc

    Masahiko Sawada <sawada.mshk@gmail.com> — 2019-06-10T09:09:53Z

    On Mon, Jun 10, 2019 at 5:05 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Jun 07, 2019 at 06:07:34PM +0900, Masahiko Sawada wrote:
> > We support ALTER TABLE ADD COLUMN .. GENERATED ALWAYS AS .. but the
> > doc is missing it. Attached small patch fixes this.
>
> Your patch updates the section related to constraint_name.  Don't you
> need an extra line for the "action" part?

We already have the following line in action part but you mean we need
an extra line for that?

   ADD [ COLUMN ] [ IF NOT EXISTS ] column_name data_type [ COLLATE
collation ] [ column_constraint [ ... ] ]

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

  4. Re: Missing generated column in ALTER TABLE ADD COLUMN doc

    Michael Paquier <michael@paquier.xyz> — 2019-06-11T04:02:28Z

    On Mon, Jun 10, 2019 at 06:09:53PM +0900, Masahiko Sawada wrote:
> We already have the following line in action part but you mean we need
> an extra line for that?
> 
>    ADD [ COLUMN ] [ IF NOT EXISTS ] column_name data_type [ COLLATE
> collation ] [ column_constraint [ ... ] ]

I was looking at the grammar extensions for ADD GENERATED and noticed
what looked like inconsistencies, but your patch as well as the parsed
query are right.  Committed, thanks!
--
Michael

  5. Re: Missing generated column in ALTER TABLE ADD COLUMN doc

    Masahiko Sawada <sawada.mshk@gmail.com> — 2019-06-11T04:49:02Z

    On Tue, Jun 11, 2019 at 1:02 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Mon, Jun 10, 2019 at 06:09:53PM +0900, Masahiko Sawada wrote:
> > We already have the following line in action part but you mean we need
> > an extra line for that?
> >
> >    ADD [ COLUMN ] [ IF NOT EXISTS ] column_name data_type [ COLLATE
> > collation ] [ column_constraint [ ... ] ]
>
> I was looking at the grammar extensions for ADD GENERATED and noticed
> what looked like inconsistencies, but your patch as well as the parsed
> query are right.  Committed, thanks!

Thank you!

Regards,

--
Masahiko Sawada
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center