Re: effective_wal_level is not decreasing after using REPACK (CONCURRENTLY)
Masahiko Sawada <sawada.mshk@gmail.com>
From: Masahiko Sawada <sawada.mshk@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: shveta malik <shveta.malik@gmail.com>,
Imran Zaheer <imran.zhir@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>,
shveta malik <shvetamalik@gmail.com>
Date: 2026-05-27T19:21:18Z
Lists: pgsql-hackers
Attachments
On Wed, May 27, 2026 at 11:56 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > On Wed, May 27, 2026 at 11:25 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote: > > > > On Wed, May 27, 2026 at 11:20 AM Álvaro Herrera <alvherre@kurilemu.de> wrote: > > > > > > On 2026-May-26, shveta malik wrote: > > > > > > > On Tue, May 26, 2026 at 3:09 PM Imran Zaheer <imran.zhir@gmail.com> wrote: > > > > > > > > > > Hi, > > > > > > > > > > Thanks Shveta, I agree with the additional sanity checks and comments. > > > > > > > > Thanks, v3 LGTM. > > > > > > Thanks! Pushed with some cosmetic changes. > > > > Thank you for pushing the patch! > > Some buildfarm members reported failures[1][2]. The newly added test > works only on builds without injection points because the logical slot > "test_slot" is removed during tests using injection points, otherwise > it still exists on the primary server at the end of > 051_effective_wal_level.pl. > I've attached the patch to fix the issue by moving the new test earlier in the test script, so it no longer depends on slot state. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com