Re: Skipping logical replication transactions on subscriber side

Masahiko Sawada <sawada.mshk@gmail.com>

From: Masahiko Sawada <sawada.mshk@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: Greg Nancarrow <gregn4422@gmail.com>, "tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>, "osumi.takamichi@fujitsu.com" <osumi.takamichi@fujitsu.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Alexey Lesovsky <lesovsky@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-08-30T07:06:55Z

Lists: pgsql-hackers

Attachments

v12-0001-Add-pg_stat_subscription_errors-statistics-view.patch (application/octet-stream) patch v12-0001
v12-0003-Add-skip_xid-option-to-ALTER-SUBSCRIPTION.patch (application/octet-stream) patch v12-0003
v12-0004-Using-fileset-more-effectively-in-the-apply-work.patch (application/octet-stream) patch v12-0004
v12-0002-Add-RESET-command-to-ALTER-SUBSCRIPTION-command.patch (application/octet-stream) patch v12-0002

On Fri, Aug 27, 2021 at 8:03 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> On Fri, Aug 27, 2021 at 1:36 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Thu, Aug 26, 2021 at 6:24 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > >
> > > On Thu, Aug 26, 2021 at 9:11 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > >
> > > >
> > > > Okay, changed accordingly. Additionally, I have changed the code which
> > > > sets timestamp to (unset) when it is 0 so that it won't display the
> > > > timestamp in that case. I have made few other cosmetic changes in the
> > > > attached patch. See and let me know what you think of it?
> > >
> > > Thank you for the patch!
> > >
> > > Agreed with these changes. The patch looks good to me.
> > >
> >
> > Pushed, feel free to rebase and send the remaining patch set.
>
> Thanks!
>
> I'll post the updated version patch on Monday.

I've attached rebased patches. 0004 patch is not the scope of this
patch. It's borrowed from another thread[1] to fix the assertion
failure for newly added tests. Please review them.

Regards,

[1] https://www.postgresql.org/message-id/CAFiTN-v-zFpmm7Ze1Dai5LJjhhNYXvK8QABs35X89WY0HDG4Ww%40mail.gmail.com

-- 
Masahiko Sawada
EDB:  https://www.enterprisedb.com/

Commits

Test ALIGNOF_DOUBLE==4 compatibility under ALIGNOF_DOUBLE==8.
- c1da0acbb06e 15.0 landed
Reorder subskiplsn in pg_subscription to avoid alignment issues.
- 79b716cfb7a1 15.0 landed
Add ALTER SUBSCRIPTION ... SKIP.
- 208c5d65bbd6 15.0 landed
Optionally disable subscriptions on error.
- 705e20f8550c 15.0 cited
Update docs of logical replication for commit 8d74fc96db.
- 85c61ba8920b 15.0 landed
Respect permissions within logical replication.
- a2ab9c06ea15 15.0 cited
Fix regression test failure caused by commit 8d74fc96db.
- 41e66fee0516 15.0 landed
Add a view to show the stats of subscription workers.
- 8d74fc96db5f 15.0 landed
Add logical change details to logical replication worker errcontext.
- abc0910e2e0a 15.0 landed
Rename LOGICAL_REP_MSG_STREAM_END to LOGICAL_REP_MSG_STREAM_STOP.
- 4cd7a1896871 15.0 landed
Fix typo in protocol.sgml.
- e1915646658d 14.0 landed
- 0ac1aee0d7d8 15.0 landed
Remove unused argument in apply_handle_commit_internal().
- f4b939f1a372 14.0 landed
- 16bd4becee32 15.0 landed
Fix replication of in-progress transactions in tablesync worker.
- 0926e96c4934 14.0 cited
Reorder pg_sequence columns to avoid alignment issue
- f3b421da5f4a 10.0 cited