Re: [PATCH] Refactor *_abbrev_convert() functions

Aditya Gollamudi <adigollamudi@gmail.com>

From: Aditya Gollamudi <adigollamudi@gmail.com>

To: Aleksander Alekseev <aleksander@tigerdata.com>

Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>

Date: 2026-01-24T22:27:04Z

Lists: pgsql-hackers

On Tue, Jan 13, 2026 at 4:34 AM Aleksander Alekseev <
aleksander@tigerdata.com> wrote:

> Hi,
>
> Now when all Datums are 64-bit values we can simplify the code by
> using murmurhash64(). This refactoring was previously suggested by
> John Naylor [1].
>
> [1]:
> https://postgr.es/m/CANWCAZbMyrijdR0xc-4SqpNJBHMEwRZccBK4fa0aquNpq2Uj7w%40mail.gmail.com
>
> --
> Best regards,
> Aleksander Alekseev
>

Hi,

I reviewed this change and the surrounding code and this seems good!
All tests pass locally for me. Hopefully this gets picked up soon.

Regards,
Adi Gollamudi