Horton
Menu

Re: PL/Python: Fix return in the middle of PG_TRY() block.

Xing Guo <higuoxing@gmail.com>

View thread
From: Xing Guo <higuoxing@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>
Date: 2023-05-05T01:40:32Z
Lists: pgsql-hackers 
Sorry for not responding to this thread for a long time and a huge thank
you for pushing it forward!

Best Regards,
Xing








On Fri, May 5, 2023 at 7:42 AM Nathan Bossart <nathandbossart@gmail.com>
wrote:

> On Thu, May 04, 2023 at 08:39:03AM -0400, Tom Lane wrote:
> > Hmm, I'm not sure why PLy_trigger_build_args's pltargs needs to
> > gain a "volatile" here?  LGTM otherwise.
>
> I removed that new "volatile" marker before committing.  I was trying to
> future-proof a bit and follow elog.h's recommendation to the letter, but
> following your mental model upthread, it doesn't seem to be strictly
> necessary, and we'd need to set pltargs to NULL after decrementing its
> reference count in the PG_TRY section for such future-proofing to be
> effective, anyway.
>
> Thank you for reviewing!
>
> --
> Nathan Bossart
> Amazon Web Services: https://aws.amazon.com
>

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Move return statements out of PG_TRY blocks.