Re: Set appropriate processing mode for auxiliary processes.
Xing Guo <higuoxing@gmail.com>
From: Xing Guo <higuoxing@gmail.com>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2024-05-09T14:55:57Z
Lists: pgsql-hackers
Attachments
- v2-0001-Remove-redundant-SetProcessingMode-InitProcessing.patch (text/x-patch) patch v2-0001
On Thu, May 9, 2024 at 10:13 PM Heikki Linnakangas <hlinnaka@iki.fi> wrote: > > On 09/05/2024 16:12, Xing Guo wrote: > > Hi hackers, > > > > After several refactoring iterations, auxiliary processes are no > > longer initialized from the bootstrapper. I think using the > > InitProcessing mode for initializing auxiliary processes is more > > appropriate. > > At first I was sure this was introduced by my refactorings in v17, but > in fact it's been like this forever. I agree that InitProcessing makes > much more sense. The ProcessingMode variable is initialized to > InitProcessing, so I think we can simply remove that line from > AuxiliaryProcessMainCommon(). There are existing > "SetProcessingMode(InitProcessing)" calls in other Main functions too > (AutoVacLauncherMain, BackgroundWorkerMain, etc.), and I think those can > also be removed. Good catch! I agree with you. Best Regards, Xing.
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Remove redundant SetProcessingMode(InitProcessing) calls
- eb21f5bc67a0 18.0 landed
-
Move bgworker specific logic to bgworker.c
- 4d22173ec08c 18.0 landed