Horton
Menu

Re: JIT: Remove some unnecessary instructions.

Xing Guo <higuoxing@gmail.com>

View thread
From: Xing Guo <higuoxing@gmail.com>
To: Andreas Karlsson <andreas@proxel.se>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2024-09-02T02:23:49Z
Lists: pgsql-hackers

Attachments

On Fri, Aug 30, 2024 at 8:50 PM Andreas Karlsson <andreas@proxel.se> wrote:
>
> On 8/30/24 5:55 AM, Xing Guo wrote:
> > I find there are some unnecessary load/store instructions being
> > emitted by the JIT compiler.
>
> Well spotted! All of these are obvious dead instructions and while LLVM
> might be able to optimize them away there is no reason to create extra
> work for the optimizer.
>
> The patch looks good, applies and the tests passes.

Thanks for testing it! I spotted another unnecessary store instruction
and added it in my V2 patch.

Best Regards,
Xing

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. jit: Stop emitting some unnecessary instructions