Horton
Menu

Remove obsolete check for TTSOpsVirtual from slot_compile_deform

Xing Guo <higuoxing@gmail.com>

View thread
From: Xing Guo <higuoxing@gmail.com>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-10-30T14:58:49Z
Lists: pgsql-hackers

Attachments

Hi hackers,

While exploring the JIT support for tuple deforming process, I noticed that
one check for TTSOpsVirtual in slot_compile_deform is obsolete. Since
virtual tuples never need deforming and there's an assertion in
llvm_compile_expr[1]. I simply replace it with an assertion in
slot_compile_deform. Patch is attached.

[1]
https://github.com/postgres/postgres/blob/0c60e8ba80e03491b028204a19a9dca6d216df91/src/backend/jit/llvm/llvmjit_expr.c#L322

Best Regards,
Xing

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fill in more of ObjectProperty