Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Reject missing database name in pg_regress and cohorts.

  1. pg_regress/pg_isolation_regress: Fix possible nullptr dereference.

    Xing Guo <higuoxing@gmail.com> — 2022-11-30T15:02:35Z

    Hi hackers,

While playing with pg_regress and pg_isolation_regress, I noticed that
there's a potential nullptr deference in both of them.

How to reproduce:

Specify the `--dbname=` option without providing any database name.

<path>/<to>/pg_regress --dbname=   foo
<path>/<to>/pg_isolation_regress --dbname=   foo

Patch is attached.

-- 
Best Regards,
Xing

  2. Re: pg_regress/pg_isolation_regress: Fix possible nullptr dereference.

    Tom Lane <tgl@sss.pgh.pa.us> — 2022-11-30T16:59:48Z

    Xing Guo <higuoxing@gmail.com> writes:
> While playing with pg_regress and pg_isolation_regress, I noticed that
> there's a potential nullptr deference in both of them.
> How to reproduce:
> Specify the `--dbname=` option without providing any database name.

Hmm, yeah, I see that too.

> Patch is attached.

This patch seems like a band-aid, though.  The reason nobody's
noticed this for decades is that it doesn't make a lot of sense
to allow tests to run in your default database: the odds of them
screwing up something valuable are high, and the odds that they'll
fail if started in a nonempty database are even higher.

I think the right answer is to treat it as an error if we end up
with an empty dblist (or even a zero-length name).

			regards, tom lane