Re: Implement targetlist SRFs using ROWS FROM() (was Changed SRF in targetlist handling)
Kevin Grittner <kgrittn@gmail.com>
From: Kevin Grittner <kgrittn@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2016-09-02T14:05:35Z
Lists: pgsql-hackers
On Fri, Sep 2, 2016 at 3:31 AM, Robert Haas <robertmhaas@gmail.com> wrote: > On Tue, Aug 23, 2016 at 3:10 AM, Andres Freund <andres@anarazel.de> wrote: >> =# SELECT * FROM few, ROWS FROM(generate_series(1,3)); >> ┌────┬─────────────────┐ >> │ id │ generate_series │ >> ├────┼─────────────────┤ >> │ 1 │ 1 │ >> │ 2 │ 1 │ >> │ 1 │ 2 │ >> │ 2 │ 2 │ >> │ 1 │ 3 │ >> │ 2 │ 3 │ >> └────┴─────────────────┘ >> (6 rows) >> surely isn't what was intended. So the join order needs to be enforced. > > In general, we've been skeptical about giving any guarantees about > result ordering. +1 I think it is a very bad idea to move away from the statement that a query generates a set of rows, and that no order is guaranteed unless the top level has an ORDER BY clause. How hard is it to add ORDER BY 1, 2 to the above query? Let the optimizer notice when a node returns data in the needed order and skip the sort if possible. -- Kevin Grittner EDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Commits
-
Remove obsoleted code relating to targetlist SRF evaluation.
- ea15e18677fc 10.0 landed
-
Doc: improve documentation of new SRF-in-tlist behavior.
- f13a1277aa2d 10.0 landed
-
Move targetlist SRF handling from expression evaluation to new executor node.
- 69f4b9c85f16 10.0 landed
-
Don't split up SRFs when choosing to postpone SELECT output expressions.
- d543170f2fdd 9.6.0 cited