Re: Avoid unused value (src/fe_utils/print.c)

Karina Litskevich <litskevichkarina@gmail.com>

From: Karina Litskevich <litskevichkarina@gmail.com>

To: Ranier Vilela <ranier.vf@gmail.com>

Cc: marko@joh.to, Alexander Lakhin <exclusion@gmail.com>, Michael Paquier <michael@paquier.xyz>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2023-07-21T12:13:02Z

Lists: pgsql-hackers

Attachments

v2-0001-Avoid-unused-value-in-print.patch (text/x-patch) patch v2-0001

On Wed, Jul 12, 2023 at 1:46 AM Ranier Vilela <ranier.vf@gmail.com> wrote:

>  As there is consensus to keep the no-op assignment,
> I will go ahead and reject the patch.
>

In your patch you suggest removing two assignments, and we only have
consensus to keep one of them. The other one is an obvious no-op.

I attached a patch that removes only one assignment. Could you please try
it and check whether Coverity is still complaining about need_recordsep
variable?

Best regards,
Karina Litskevich
Postgres Professional: http://postgrespro.com/